Skip to content

Rename BucketBatcher argument to avoid name collision #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Rename BucketBatcher argument to avoid name collision #304

wants to merge 4 commits into from

Conversation

@NivekT
Copy link
Contributor

@NivekT NivekT commented Mar 16, 2022 •
edited
Loading

Stack from ghstack:

We have a DataPipe using the functional API name in_batch_shuffle. Therefore, this DataPipe should not have a class variable with the same name to avoid confusion.

Differential Revision: D34939045

@NivekT NivekT mentioned this pull request Mar 16, 2022
Closed
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 16, 2022
NivekT added a commit that referenced this pull request Mar 16, 2022
@NivekT
Rename BucketBatcher argument to avoid name collision
e1dd30d 
ghstack-source-id: d22739f
Pull Request resolved: #304
@NivekT NivekT requested a review from ejguan March 16, 2022 19:36
ejguan
ejguan approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it.
I was also thinking to change the name of this DataPipe to Bucketizer with functional name bucketize in favor of this commonly used name (https://www.tensorflow.org/tfx/transform/api_docs/python/tft/bucketize)

@NivekT
Copy link
Contributor Author

NivekT commented Mar 16, 2022

Thanks for fixing it. I was also thinking to change the name of this DataPipe to Bucketizer with functional name bucketize in favor of this commonly used name (https://www.tensorflow.org/tfx/transform/api_docs/python/tft/bucketize)

I think that seems reasonable. We will have to go through the deprecation process.

@NivekT
Copy link
Contributor Author

NivekT commented Mar 16, 2022

@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@NivekT
Update on "Rename BucketBatcher argument to avoid name collision"
5f27161 
We have a DataPipe using the functional API name `in_batch_shuffle`. Therefore, this DataPipe should **not** have a class variable with the same name to avoid confusion.

Differential Revision: [D34939045](https://our.internmc.facebook.com/intern/diff/D34939045)

[ghstack-poisoned]
NivekT added a commit that referenced this pull request Mar 16, 2022
@NivekT
Rename BucketBatcher argument to avoid name collision
5d5713d 
ghstack-source-id: 7957da1
Pull Request resolved: #304
@NivekT
Update on "Rename BucketBatcher argument to avoid name collision"
585f6b5 
We have a DataPipe using the functional API name `in_batch_shuffle`. Therefore, this DataPipe should **not** have a class variable with the same name to avoid confusion.

Differential Revision: [D34939045](https://our.internmc.facebook.com/intern/diff/D34939045)

[ghstack-poisoned]
NivekT added a commit that referenced this pull request Mar 16, 2022
@NivekT
Rename BucketBatcher argument to avoid name collision
7bae584 
ghstack-source-id: b65ab25
Pull Request resolved: #304
@NivekT
Copy link
Contributor Author

NivekT commented Mar 16, 2022

@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@NivekT
Update on "Rename BucketBatcher argument to avoid name collision"
afbca4d 
We have a DataPipe using the functional API name `in_batch_shuffle`. Therefore, this DataPipe should **not** have a class variable with the same name to avoid confusion.

Differential Revision: [D34939045](https://our.internmc.facebook.com/intern/diff/D34939045)

[ghstack-poisoned]
NivekT added a commit that referenced this pull request Mar 21, 2022
@NivekT
Rename BucketBatcher argument to avoid name collision
61ef2a5 
ghstack-source-id: 694d0b2
Pull Request resolved: #304
@NivekT
Copy link
Contributor Author

NivekT commented Mar 21, 2022

@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot deleted the gh/NivekT/63/head branch March 25, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ejguan ejguan ejguan approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NivekT @ejguan @facebook-github-bot